RFR: 2222: Remove JbsVault [v2]

[Erik Duveblad]

On Wed, 3 Apr 2024 23:05:11 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Erik Duveblad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update comment
>
> issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssueTrackerFactory.java line 53:
> 
>> 51:             } else {
>> 52:                 if (credential.username().isEmpty() && !credential.password().isEmpty()) {
>> 53:                     return createWithPat(uri, credential.password());
> 
> The comment on this method needs to be updated as it's now called from non test code. Even if we are only using it for tests in practice, that isn't enforced anywhere, so the current comment is misleading.

I agree, I updated the comment both for the `createWithPat` method and added a comment in the `if`-branch. Fixed in latest.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1628#discussion_r1551090556