RFR: 2228: Remove JbsBackports

Erik Duveblad ehelin at openjdk.org
Thu Apr 11 18:02:02 UTC 2024


On Thu, 11 Apr 2024 16:53:00 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that removes the class `JbsBackports`. The class `JbsBackports` was created because the `Backports` class in the `org.openjdk.skara.jbs` module did not have a way to create a backport via an `IssueTracker` instance. Thanks to 42cae169d it is now possible to create a backport using only an `IssueTracker` instance, so the creation of backports can now be moved to the `Backports` class where it belongs.
>> 
>> I also moved the integration test `JbsBackportIntegrationTests` to `BackportsIntegrationTests` and changed the properties to start with `jbs.*` instead of `jira.*` (because this about testing a JBS instance, not a general JIRA instance). I have run the the integration tests and they are passing.
>> 
>> Thanks,
>> Erik
>
> Looks good!

Thanks @zhaosongzs and @erikj79 for reviewing!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1632#issuecomment-2050221023


More information about the skara-dev mailing list