RFR: 2170: Warn on trailing period in PR titles
Magnus Ihse Bursie
ihse at openjdk.org
Wed Apr 17 18:55:32 UTC 2024
On Mon, 15 Apr 2024 22:45:30 GMT, Zhao Song <zsong at openjdk.org> wrote:
> This patch is trying to add a new jcheck called "issuestitle". This jcheck would check if the issue's title has a trailing period. And we would like to configure "issuestitle" jcheck as warning in the repos since in some cases, trailing periods are valid.
>
> When implementing this, I found that although we can configure a jcheck as warning in the jcheck configuration file(.jcheck/conf), we fail to differentiate between jchecks as error and jchecks as warning. When jchecks fail as warnings, they cause the local jcheck to exit with a status code of 1. Also, they will be integration blockers when Skara bots evaluate pull requests. Therefore, in this patch, I also make Skara CLI and Skara bots be able to handle jcheck warnings properly.
I looked at the code to try to answer my own question, but could not find out an easy answer, so I'll say it out loud instead:
How do you make it so that this is a warning only, and not a blocking error?
-------------
PR Comment: https://git.openjdk.org/skara/pull/1638#issuecomment-2058531054
More information about the skara-dev
mailing list