RFR: 2244: SecurityLevel in JiraHost is useless [v3]

Erik Joelsson erikj at openjdk.org
Fri Apr 26 20:37:20 UTC 2024


On Fri, 26 Apr 2024 20:04:58 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> SecurityLevel in JiraHost is rarely used and sometimes it will conflict with the security configuration of issueNotifier. So there is no point to keep it. Also, I removed the support of `/issue create` command in this patch as ErikJ suggested. 
>> 
>> There is one useful usage of `securityLevel`, it's in `JiraIssue#addWebLink`, skara bot uses the security to determine if the link should be posted as a comment. But I think it can be replaced by checking the visibilityRole of the jiraHost.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1642#pullrequestreview-2025825800


More information about the skara-dev mailing list