RFR: 2234: /reviewers N should remove ready status for merge pull requests

[Kevin Rushforth]

On Tue, 16 Apr 2024 17:30:56 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In this pr https://github.com/openjdk/jfx22u/pull/26, Kevin issued "/reviewers 1" in the merge pull request but skara didn't remove the ready label.
> 
> Jfx22u was not configured with “reviewMerge”, so the reviewers jcheck were skipped. The reason we can see `Change must be properly reviewed (1 review required, with at least 1 Reviewer)` in the PR body is because of [SKARA-1824](https://bugs.openjdk.org/browse/SKARA-1824).
> 
> To resolve this issue, we should enable `reviewMerge` when a reviewers command is issued in a merge pull request.

I think this is OK, since the situations where we would want to issue the `/reviewer` command are when we do want to make it blocking (if we don't want to make it blocking, we can ask for a review without bumping the minimum).

-------------

PR Comment: https://git.openjdk.org/skara/pull/1639#issuecomment-2083669533