Integrated: 2234: /reviewers N should remove ready status for merge pull requests

Zhao Song zsong at openjdk.org
Mon Apr 29 22:04:27 UTC 2024


On Tue, 16 Apr 2024 17:30:56 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In this pr https://github.com/openjdk/jfx22u/pull/26, Kevin issued "/reviewers 1" in the merge pull request but skara didn't remove the ready label.
> 
> Jfx22u was not configured with “reviewMerge”, so the reviewers jcheck were skipped. The reason we can see `Change must be properly reviewed (1 review required, with at least 1 Reviewer)` in the PR body is because of [SKARA-1824](https://bugs.openjdk.org/browse/SKARA-1824).
> 
> To resolve this issue, we should enable `reviewMerge` when a reviewers command is issued in a merge pull request.

This pull request has now been integrated.

Changeset: 7e810cac
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/7e810cac854f2f55cc7fb85f76b4ebc6cabaf2c6
Stats:     77 lines in 2 files changed: 75 ins; 2 del; 0 mod

2234: /reviewers N should remove ready status for merge pull requests

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1639


More information about the skara-dev mailing list