RFR: 2247: When pr's headHash is missing, stop further processing [v2]
Zhao Song
zsong at openjdk.org
Mon Apr 29 22:54:48 UTC 2024
> Kevin Rushforth found this GitLab issue few years ago.
>
> Sometimes, pull requests in GitLab would be stuck. When it happens, it shows the number of commits as "0". Clicking on the "Changes" tab shows no diffs, and displays a warning banner: "Something went wrong on our end. Please try again!" This requires action on user's part to get them "unstuck".
>
> In Skara side, when it happens, pull request bot would not be able to get the headHash of this pull request and then throw an exception and trigger an other round of CheckWorkItem. If the user doesn't fix it, skara bot will continuously work on the pull request.
>
> To resolve it, we should try to make pull request bot be able to identify this situation and provide some guidance to the users.
Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
- Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
- Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
-------------
Changes:
- all: https://git.openjdk.org/skara/pull/1645/files
- new: https://git.openjdk.org/skara/pull/1645/files/61ae8b5d..a3945c42
Webrevs:
- full: https://webrevs.openjdk.org/?repo=skara&pr=1645&range=01
- incr: https://webrevs.openjdk.org/?repo=skara&pr=1645&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/skara/pull/1645.diff
Fetch: git fetch https://git.openjdk.org/skara.git pull/1645/head:pull/1645
PR: https://git.openjdk.org/skara/pull/1645
More information about the skara-dev
mailing list