RFR: 2247: When pr's headHash is missing, stop further processing [v5]
Erik Joelsson
erikj at openjdk.org
Tue Apr 30 12:26:13 UTC 2024
On Tue, 30 Apr 2024 00:04:07 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> Kevin Rushforth found this GitLab issue few years ago.
>>
>> Sometimes, pull requests in GitLab would be stuck. When it happens, it shows the number of commits as "0". Clicking on the "Changes" tab shows no diffs, and displays a warning banner: "Something went wrong on our end. Please try again!" This requires action on user's part to get them "unstuck".
>>
>> In Skara side, when it happens, pull request bot would not be able to get the headHash of this pull request and then throw an exception and trigger an other round of CheckWorkItem. If the user doesn't fix it, skara bot will continuously work on the pull request.
>>
>> To resolve it, we should try to make pull request bot be able to identify this situation and provide some guidance to the users.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>
> review comment
Marked as reviewed by erikj (Lead).
-------------
PR Review: https://git.openjdk.org/skara/pull/1645#pullrequestreview-2031173262
More information about the skara-dev
mailing list