RFR: 2331: Improve review notes [v3]

Erik Joelsson erikj at openjdk.org
Fri Aug 9 20:26:59 UTC 2024


On Fri, 9 Aug 2024 20:22:08 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> To further clarify, the algorithm you propose applies to the usual case where some commits have been added on top of those reviewed; and not to the more rare cases, where either the reviewed commit is no longer present or the PR has changed its target branch. Is that correct?
>
> I'm ok with Kevin's proposed behavior, but I'm not sure what the significance of your last question is, Pavel. Are we behaving differently today when the commit has gone missing or the branch has changed?

Also, when this is all done, could you summarize the complete behavior in the bug description, or comment, similar to how Kevin presented it here?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1679#discussion_r1712151573


More information about the skara-dev mailing list