RFR: 2331: Improve review notes [v3]

[Erik Joelsson]

On Mon, 12 Aug 2024 10:16:42 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Also, when this is all done, could you summarize the complete behavior in the bug description, or comment, similar to how Kevin presented it here?
>
>> I'm not sure what the significance of your last question is, Pavel. Are we behaving differently today when the commit has gone missing or the branch has changed?
> 
> In either of those two cases, in master, we display the "🔄" emoji and the word "required" regardless of whether the PR has been sufficiently reviewed:
> 
> https://github.com/openjdk/skara/blob/45468cde2dc5273c70f728c46c6b133e3d16b55a/bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java#L602-L622
> 
> If we are trying to generally improve review notes, we perhaps should treat those two cases similarly to our main/typical case?

I agree, those cases should be folded into the new behavior with regards to emojis.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1679#discussion_r1713819114