RFR: 2340: CommitCommentsWorkItem executing in GitLab takes a lot of time [v3]

[Zhao Song]

On Tue, 13 Aug 2024 12:35:39 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update
>
> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java line 646:
> 
>> 644:             var hash = new Hash(commit.get("id").asString());
>> 645:             var title = commit.get("title").asString();
>> 646:             ((LinkedHashSet<Hash>) commitTitleToCommits.computeIfAbsent(title, t -> new LinkedHashSet<>())).addFirst(hash);
> 
> Instead of casting to LinkedHashSet, we can use the type directly in the type declaration for `commitTitleToCommits`. We can even use the new shiny `SequencedSet` interface to avoid specifying the concrete class.

Sure

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1682#discussion_r1715581244