RFR: 2331: Improve review notes [v4]

Pavel Rappo prappo at openjdk.org
Mon Aug 19 19:10:28 UTC 2024


On Mon, 19 Aug 2024 17:00:55 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> I think it's ok to return the list of jcheck issues, but the variable name `issues` can be confusing as an `Issue` in the bots is usually some form of Jira Issue. I would recommend `jcheckIssues` to avoid confusion.
>
> Could you rename the variable `issues` to something more descriptive?

Fair enough. I can see that "issue" is an overloaded term in the Skara domain:

  - org.openjdk.skara.issuetracker.Issue
  - org.openjdk.skara.jcheck.Issue

One word, two meanings. Does `jcheckIssues` sound better to you?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1679#discussion_r1722232655


More information about the skara-dev mailing list