RFR: 2331: Improve review notes [v5]
Pavel Rappo
prappo at openjdk.org
Mon Aug 19 20:59:36 UTC 2024
> There are two variants of a note that can be added to an item in the "Reviewers" list of a PR body:
>
> - 🔄 Re-review required ...
> - ⚠️ Review applies to ...
>
> That note may confuse or draw unneeded attention to the PR body.
>
> Firstly, as a result of recently integrated [SKARA-2312][], "⚠️ Review applies to ..." is also added to an item (i.e. review) that applies to the head of the PR. Secondly, "🔄 Re-review required (review applies to ..." may be present for some items even though a PR has the green "ready" label.
>
> [SKARA-2312]: https://bugs.openjdk.org/browse/SKARA-2312
Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
Rename a variable
-------------
Changes:
- all: https://git.openjdk.org/skara/pull/1679/files
- new: https://git.openjdk.org/skara/pull/1679/files/cd128621..f4dde9b4
Webrevs:
- full: https://webrevs.openjdk.org/?repo=skara&pr=1679&range=04
- incr: https://webrevs.openjdk.org/?repo=skara&pr=1679&range=03-04
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/skara/pull/1679.diff
Fetch: git fetch https://git.openjdk.org/skara.git pull/1679/head:pull/1679
PR: https://git.openjdk.org/skara/pull/1679
More information about the skara-dev
mailing list