RFR: 2331: Improve review notes [v5]

Erik Joelsson erikj at openjdk.org
Mon Aug 19 21:03:29 UTC 2024


On Mon, 19 Aug 2024 20:59:36 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> There are two variants of a note that can be added to an item in the "Reviewers" list of a PR body:
>> 
>>   - 🔄 Re-review required ...
>>   - ⚠️ Review applies to ...
>> 
>> That note may confuse or draw unneeded attention to the PR body.
>> 
>> Firstly, as a result of recently integrated [SKARA-2312][], "⚠️ Review applies to ..." is also added to an item (i.e. review) that applies to the head of the PR. Secondly, "🔄 Re-review required (review applies to ..." may be present for some items even though a PR has the green "ready" label.
>> 
>> [SKARA-2312]: https://bugs.openjdk.org/browse/SKARA-2312
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rename a variable

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1679#pullrequestreview-2246452690


More information about the skara-dev mailing list