Integrated: 2331: Improve review notes

Pavel Rappo prappo at openjdk.org
Mon Aug 19 21:55:39 UTC 2024


On Thu, 18 Jul 2024 10:52:54 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> There are two variants of a note that can be added to an item in the "Reviewers" list of a PR body:
> 
>   - 🔄 Re-review required ...
>   - ⚠️ Review applies to ...
> 
> That note may confuse or draw unneeded attention to the PR body.
> 
> Firstly, as a result of recently integrated [SKARA-2312][], "⚠️ Review applies to ..." is also added to an item (i.e. review) that applies to the head of the PR. Secondly, "🔄 Re-review required (review applies to ..." may be present for some items even though a PR has the green "ready" label.
> 
> [SKARA-2312]: https://bugs.openjdk.org/browse/SKARA-2312

This pull request has now been integrated.

Changeset: c3510610
Author:    Pavel Rappo <prappo at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/c3510610eec644df9478b988fbe3bc25ab62f808
Stats:     80 lines in 3 files changed: 44 ins; 0 del; 36 mod

2331: Improve review notes

Reviewed-by: zsong, erikj, kcr

-------------

PR: https://git.openjdk.org/skara/pull/1679


More information about the skara-dev mailing list