From erikj at openjdk.org Tue Dec 3 18:47:47 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 3 Dec 2024 18:47:47 GMT Subject: RFR: 2418: Scratch dir clash in notifier Message-ID: The notifier RepositoryWorkItem and PullRequestWorkItem have a clash between directory location for the history repos. In RepositoryWorkItem we store the tags and branches history in these directories: /notify/history/tags /notify/history/branches While in the PullRequestWorkItem, the history is stored in: /notify/history Having repositories nested inside each other like this is causing inefficiencies at the very least, but could also potentially be harmful. As a quick fix, I propose we move the pr history to ``` /notify/history/pr ``` ------------- Commit messages: - SKARA-2418 Changes: https://git.openjdk.org/skara/pull/1700/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1700&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2418 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1700.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1700/head:pull/1700 PR: https://git.openjdk.org/skara/pull/1700 From zsong at openjdk.org Tue Dec 3 19:37:17 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 3 Dec 2024 19:37:17 GMT Subject: RFR: 2418: Scratch dir clash in notifier In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 18:42:27 GMT, Erik Joelsson wrote: > The notifier RepositoryWorkItem and PullRequestWorkItem have a clash between directory location for the history repos. In RepositoryWorkItem we store the tags and branches history in these directories: > > > /notify/history/tags > /notify/history/branches > > > While in the PullRequestWorkItem, the history is stored in: > > > /notify/history > > > Having repositories nested inside each other like this is causing inefficiencies at the very least, but could also potentially be harmful. As a quick fix, I propose we move the pr history to > > ``` > /notify/history/pr > ``` LGTM ------------- Marked as reviewed by zsong (Reviewer). PR Review: https://git.openjdk.org/skara/pull/1700#pullrequestreview-2476618869 From erikj at openjdk.org Tue Dec 3 21:13:54 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 3 Dec 2024 21:13:54 GMT Subject: Integrated: 2418: Scratch dir clash in notifier In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 18:42:27 GMT, Erik Joelsson wrote: > The notifier RepositoryWorkItem and PullRequestWorkItem have a clash between directory location for the history repos. In RepositoryWorkItem we store the tags and branches history in these directories: > > > /notify/history/tags > /notify/history/branches > > > While in the PullRequestWorkItem, the history is stored in: > > > /notify/history > > > Having repositories nested inside each other like this is causing inefficiencies at the very least, but could also potentially be harmful. As a quick fix, I propose we move the pr history to > > ``` > /notify/history/pr > ``` This pull request has now been integrated. Changeset: 49dd2200 Author: Erik Joelsson URL: https://git.openjdk.org/skara/commit/49dd2200dc96c387a373caef2b3535f2da54f531 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 2418: Scratch dir clash in notifier Reviewed-by: zsong ------------- PR: https://git.openjdk.org/skara/pull/1700 From zsong at openjdk.org Wed Dec 4 23:54:01 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 4 Dec 2024 23:54:01 GMT Subject: RFR: 2420: Remove closed pr from all entries in targetRefPRMap Message-ID: In [SKARA-1937](https://bugs.openjdk.org/browse/SKARA-1937), we introduced a feature that pull request bot can re-evaluate all PRs when jcheck configuration changes. When implementing it, I let pull request bot maintains a hash map called targetRefPRMap. The key is the name of targetRef and the value is the list of pr which targets to the targetRef. Currently, when a pr is closed, the bot will unlink it with its current targetRef. There was an issue happened recently, there was an entry {pr/96=[pr/97]} in the hash map, and before pr/97 was integrated, the user retargeted the pr from pr/96 to master, so the bot fails to remove the association between pr/96 and pr/97. I think the right behavior here is that when pull request bot finds an updated pr, it should unlink this pr with all targetRefs and if this pr is still open, the bot should link the pr with current targetRef. ------------- Commit messages: - update - update - update - SKARA-2420 Changes: https://git.openjdk.org/skara/pull/1701/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1701&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2420 Stats: 41 lines in 5 files changed: 22 ins; 5 del; 14 mod Patch: https://git.openjdk.org/skara/pull/1701.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1701/head:pull/1701 PR: https://git.openjdk.org/skara/pull/1701 From erikj at openjdk.org Thu Dec 5 00:28:50 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Thu, 5 Dec 2024 00:28:50 GMT Subject: RFR: 2420: Remove closed pr from all entries in targetRefPRMap In-Reply-To: References: Message-ID: <9ccgZ7ruMEjiIaoH87nosnjJcLz-txL5wRBR1WoxUZc=.d60a30f9-eacd-44eb-89ee-108ddbc0a37d@github.com> On Wed, 4 Dec 2024 19:57:10 GMT, Zhao Song wrote: > In [SKARA-1937](https://bugs.openjdk.org/browse/SKARA-1937), we introduced a feature that pull request bot can re-evaluate all PRs when jcheck configuration changes. When implementing it, I let pull request bot maintains a hash map called targetRefPRMap. The key is the name of targetRef and the value is the list of pr which targets to the targetRef. Currently, when a pr is closed, the bot will unlink it with its current targetRef. There was an issue happened recently, there was an entry {pr/96=[pr/97]} in the hash map, and before pr/97 was integrated, the user retargeted the pr from pr/96 to master, so the bot fails to remove the association between pr/96 and pr/97. > > I think the right behavior here is that when pull request bot finds an updated pr, it should unlink this pr with all targetRefs and if this pr is still open, the bot should link the pr with current targetRef. bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java line 241: > 239: } > 240: } catch (UncheckedRestException e) { > 241: if (e.getStatusCode() != 404) { Suggestion: // If the targetRef is invalid, fileContents() will throw a 404 instead of returning // empty. In this case we should ignore this and continue processing other PRs. // Any invalid refs will get removed from targetRefMap in the next round. if (e.getStatusCode() != 404) { ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1701#discussion_r1870452185 From zsong at openjdk.org Thu Dec 5 18:20:24 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 5 Dec 2024 18:20:24 GMT Subject: RFR: 2420: Remove closed pr from all entries in targetRefPRMap [v2] In-Reply-To: References: Message-ID: > In [SKARA-1937](https://bugs.openjdk.org/browse/SKARA-1937), we introduced a feature that pull request bot can re-evaluate all PRs when jcheck configuration changes. When implementing it, I let pull request bot maintains a hash map called targetRefPRMap. The key is the name of targetRef and the value is the list of pr which targets to the targetRef. Currently, when a pr is closed, the bot will unlink it with its current targetRef. There was an issue happened recently, there was an entry {pr/96=[pr/97]} in the hash map, and before pr/97 was integrated, the user retargeted the pr from pr/96 to master, so the bot fails to remove the association between pr/96 and pr/97. > > I think the right behavior here is that when pull request bot finds an updated pr, it should unlink this pr with all targetRefs and if this pr is still open, the bot should link the pr with current targetRef. Zhao Song has updated the pull request incrementally with one additional commit since the last revision: Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com> ------------- Changes: - all: https://git.openjdk.org/skara/pull/1701/files - new: https://git.openjdk.org/skara/pull/1701/files/1dde45cf..c52ea15d Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1701&range=01 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1701&range=00-01 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/skara/pull/1701.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1701/head:pull/1701 PR: https://git.openjdk.org/skara/pull/1701 From erikj at openjdk.org Thu Dec 5 19:10:32 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Thu, 5 Dec 2024 19:10:32 GMT Subject: RFR: 2420: Remove closed pr from all entries in targetRefPRMap [v2] In-Reply-To: References: Message-ID: On Thu, 5 Dec 2024 18:20:24 GMT, Zhao Song wrote: >> In [SKARA-1937](https://bugs.openjdk.org/browse/SKARA-1937), we introduced a feature that pull request bot can re-evaluate all PRs when jcheck configuration changes. When implementing it, I let pull request bot maintains a hash map called targetRefPRMap. The key is the name of targetRef and the value is the list of pr which targets to the targetRef. Currently, when a pr is closed, the bot will unlink it with its current targetRef. There was an issue happened recently, there was an entry {pr/96=[pr/97]} in the hash map, and before pr/97 was integrated, the user retargeted the pr from pr/96 to master, so the bot fails to remove the association between pr/96 and pr/97. >> >> I think the right behavior here is that when pull request bot finds an updated pr, it should unlink this pr with all targetRefs and if this pr is still open, the bot should link the pr with current targetRef. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java > > Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com> Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1701#pullrequestreview-2482649589 From zsong at openjdk.org Thu Dec 5 21:03:30 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 5 Dec 2024 21:03:30 GMT Subject: RFR: 2420: Remove closed pr from all entries in targetRefPRMap [v2] In-Reply-To: References: Message-ID: On Thu, 5 Dec 2024 18:20:24 GMT, Zhao Song wrote: >> In [SKARA-1937](https://bugs.openjdk.org/browse/SKARA-1937), we introduced a feature that pull request bot can re-evaluate all PRs when jcheck configuration changes. When implementing it, I let pull request bot maintains a hash map called targetRefPRMap. The key is the name of targetRef and the value is the list of pr which targets to the targetRef. Currently, when a pr is closed, the bot will unlink it with its current targetRef. There was an issue happened recently, there was an entry {pr/96=[pr/97]} in the hash map, and before pr/97 was integrated, the user retargeted the pr from pr/96 to master, so the bot fails to remove the association between pr/96 and pr/97. >> >> I think the right behavior here is that when pull request bot finds an updated pr, it should unlink this pr with all targetRefs and if this pr is still open, the bot should link the pr with current targetRef. > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java > > Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com> Thank you for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1701#issuecomment-2521403836 From zsong at openjdk.org Thu Dec 5 21:03:30 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 5 Dec 2024 21:03:30 GMT Subject: Integrated: 2420: Remove closed pr from all entries in targetRefPRMap In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 19:57:10 GMT, Zhao Song wrote: > In [SKARA-1937](https://bugs.openjdk.org/browse/SKARA-1937), we introduced a feature that pull request bot can re-evaluate all PRs when jcheck configuration changes. When implementing it, I let pull request bot maintains a hash map called targetRefPRMap. The key is the name of targetRef and the value is the list of pr which targets to the targetRef. Currently, when a pr is closed, the bot will unlink it with its current targetRef. There was an issue happened recently, there was an entry {pr/96=[pr/97]} in the hash map, and before pr/97 was integrated, the user retargeted the pr from pr/96 to master, so the bot fails to remove the association between pr/96 and pr/97. > > I think the right behavior here is that when pull request bot finds an updated pr, it should unlink this pr with all targetRefs and if this pr is still open, the bot should link the pr with current targetRef. This pull request has now been integrated. Changeset: c13468d8 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/c13468d89f90efd51ca8f89e500eb59a1c7855e4 Stats: 44 lines in 5 files changed: 25 ins; 5 del; 14 mod 2420: Remove closed pr from all entries in targetRefPRMap Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1701 From zsong at openjdk.org Thu Dec 5 22:54:28 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 5 Dec 2024 22:54:28 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck Message-ID: This patch introduces a copyright jcheck. For pull requests, the check checks the copyright header in all modified files(if the file name matches the regex in .jcheck/conf) ------------- Commit messages: - fix a copyright year - Fix a test - Fix test - update - SKARA-1357 Changes: https://git.openjdk.org/skara/pull/1702/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1702&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-1357 Stats: 460 lines in 12 files changed: 451 ins; 0 del; 9 mod Patch: https://git.openjdk.org/skara/pull/1702.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1702/head:pull/1702 PR: https://git.openjdk.org/skara/pull/1702 From darcy at openjdk.org Thu Dec 5 23:19:27 2024 From: darcy at openjdk.org (Joe Darcy) Date: Thu, 5 Dec 2024 23:19:27 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck In-Reply-To: References: Message-ID: On Thu, 5 Dec 2024 22:43:08 GMT, Zhao Song wrote: > This patch introduces a copyright jcheck. > For pull requests, the check checks the copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >From looking over the logic, I think some additional accommodations will be needed, at least for update trains. For example, if a patch from a feature release authored in 2022 is backported unchanged to an update release, the affected files should have a copyright year end date of 2022 and *not* 2024. ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2521701094 From zsong at openjdk.org Thu Dec 5 23:25:58 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 5 Dec 2024 23:25:58 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck In-Reply-To: References: Message-ID: On Thu, 5 Dec 2024 22:43:08 GMT, Zhao Song wrote: > This patch introduces a copyright jcheck. > For pull requests, the check checks the copyright header in all modified files(if the file name matches the regex in .jcheck/conf) > From looking over the logic, I think some additional accommodations will be needed, at least for update trains. For example, if a patch from a feature release authored in 2022 is backported unchanged to an update release, the affected files should have a copyright year end date of 2022 and _not_ 2024. You're right, maybe this is why Erik said "not make any attempt at verifying that files have the correct header, or that the copyright years are correct" in the issue description ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2521708951 From erikj at openjdk.org Thu Dec 5 23:28:37 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Thu, 5 Dec 2024 23:28:37 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck In-Reply-To: References: Message-ID: On Thu, 5 Dec 2024 22:43:08 GMT, Zhao Song wrote: > This patch introduces a copyright jcheck. > For pull requests, the check checks the copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >From the bug description: > Note that this feature is only about verifying the format of Oracle copyright headers. It will, for example, not make any attempt at verifying that files have the correct header, or that the copyright years are correct. These are things that need human inspection. We have a pretty well established agreement from discussing this feature over the years that we should not try to automate copyright year values. The copyright year should only be updated if a "significant" change is made to the copyrighted material. Because of this it's a judgement call each time a file is edited. The issue Joe brings up also makes it hard to automate. We simply don't have the information about when the copyrighted material was created. ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2521712730 From zsong at openjdk.org Mon Dec 9 22:51:22 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 9 Dec 2024 22:51:22 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: > This patch introduces a copyright jcheck. > For pull requests, the check checks the copyright header in all modified files(if the file name matches the regex in .jcheck/conf) Zhao Song has updated the pull request incrementally with four additional commits since the last revision: - add copyright header - version 2 - update - review comment ------------- Changes: - all: https://git.openjdk.org/skara/pull/1702/files - new: https://git.openjdk.org/skara/pull/1702/files/a0e2dd9b..33bd7217 Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1702&range=01 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1702&range=00-01 Stats: 778 lines in 17 files changed: 409 ins; 342 del; 27 mod Patch: https://git.openjdk.org/skara/pull/1702.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1702/head:pull/1702 PR: https://git.openjdk.org/skara/pull/1702 From dholmes at openjdk.org Mon Dec 9 22:51:22 2024 From: dholmes at openjdk.org (David Holmes) Date: Mon, 9 Dec 2024 22:51:22 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck In-Reply-To: References: Message-ID: <5v1JnbNag-6scRBquo-NyyDQXgucnXpSkGdnogS-QLI=.da8c40ff-d265-4481-b516-2041e154bfea@github.com> On Thu, 5 Dec 2024 23:26:30 GMT, Erik Joelsson wrote: > The copyright year should only be updated if a "significant" change is made to the copyrighted material. The copyright year is supposed to be always updated and we are not supposed to try to assess significance. ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2522202969 From ihse at openjdk.org Mon Dec 9 22:51:22 2024 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Mon, 9 Dec 2024 22:51:22 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck In-Reply-To: <5v1JnbNag-6scRBquo-NyyDQXgucnXpSkGdnogS-QLI=.da8c40ff-d265-4481-b516-2041e154bfea@github.com> References: <5v1JnbNag-6scRBquo-NyyDQXgucnXpSkGdnogS-QLI=.da8c40ff-d265-4481-b516-2041e154bfea@github.com> Message-ID: On Fri, 6 Dec 2024 05:59:09 GMT, David Holmes wrote: > > The copyright year should only be updated if a "significant" change is made to the copyrighted material. > > The copyright year is supposed to be always updated and we are not supposed to try to assess significance. I've heard both statements before, but I think what David says is the latest bid. But let's not continue this discussion here; that's really an Oracle-internal discussion. I suggest that for this patch, we do not look at what year is used, only that it conforms to the special syntax required. We can come back and update the functionality later on if we agree that the rules permit an automatic updating. ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2522529596 From kcr at openjdk.org Mon Dec 9 22:51:22 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 9 Dec 2024 22:51:22 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck In-Reply-To: References: <5v1JnbNag-6scRBquo-NyyDQXgucnXpSkGdnogS-QLI=.da8c40ff-d265-4481-b516-2041e154bfea@github.com> Message-ID: On Fri, 6 Dec 2024 08:45:08 GMT, Magnus Ihse Bursie wrote: > I suggest that for this patch, we do not look at what year is used, only that it conforms to the special syntax required. We can come back and update the functionality later on if we agree that the rules permit an automatic updating. I strongly agree with this. The reason for this PR and bug fix is to prevent the all too common error in formatting (usually a missing comma). Please let's not expand the scope to be more than that. ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2523012532 From erikj at openjdk.org Mon Dec 9 22:51:23 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Mon, 9 Dec 2024 22:51:23 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 22:47:36 GMT, Zhao Song wrote: >> This patch introduces a copyright jcheck. >> For pull requests, the check checks the copyright header in all modified files(if the file name matches the regex in .jcheck/conf) > > Zhao Song has updated the pull request incrementally with four additional commits since the last revision: > > - add copyright header > - version 2 > - update > - review comment jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightCheck.java line 67: > 65: var copyrightFound = false; > 66: for (String line : lines) { > 67: if (line.contains("Copyright (c)") && line.contains("Oracle")) { I think it would be nice if we could work with pairs of regular expressions. One for identifying a line that should match and one that verifies the format. This way we could make it possible to add more variants through configuration. We could also consider not having any default and put the Oracle config in .jcheck/conf. jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightConfiguration.java line 29: > 27: public class CopyrightConfiguration { > 28: static final CopyrightConfiguration DEFAULT = > 29: new CopyrightConfiguration(".*\\.cpp|.*\\.hpp|.*\\.c|.*\\.h|.*\\.java"); I would like to see more filetypes included by default. At least `Makefile`, `*.gmk`, `configure`, `*.m4`, `*.md` and `*.properties`. Probably also `*.cc`, `*.hh` and `*.m`. We could also consider not defining defaults here and have it all in .jcheck/conf for better visibility. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1872305344 PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1872307546 From ihse at openjdk.org Mon Dec 9 22:51:23 2024 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Mon, 9 Dec 2024 22:51:23 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: On Thu, 5 Dec 2024 23:31:09 GMT, Erik Joelsson wrote: >> Zhao Song has updated the pull request incrementally with four additional commits since the last revision: >> >> - add copyright header >> - version 2 >> - update >> - review comment > > jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightCheck.java line 67: > >> 65: var copyrightFound = false; >> 66: for (String line : lines) { >> 67: if (line.contains("Copyright (c)") && line.contains("Oracle")) { > > I think it would be nice if we could work with pairs of regular expressions. One for identifying a line that should match and one that verifies the format. This way we could make it possible to add more variants through configuration. > > We could also consider not having any default and put the Oracle config in .jcheck/conf. I'm not sure its better to have Oracle in the configuration file. It kind of just highlights it as a special case. If/when some other company requests special copyright checks, then we can generalize and move it to the configuration file. Also, it's never the case that this is just a per-repo setting: for Oracle-copyrighted code, this rule always applies. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1872824149 From zsong at openjdk.org Mon Dec 9 22:51:23 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 9 Dec 2024 22:51:23 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: On Thu, 5 Dec 2024 23:34:43 GMT, Erik Joelsson wrote: >> Zhao Song has updated the pull request incrementally with four additional commits since the last revision: >> >> - add copyright header >> - version 2 >> - update >> - review comment > > jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightConfiguration.java line 29: > >> 27: public class CopyrightConfiguration { >> 28: static final CopyrightConfiguration DEFAULT = >> 29: new CopyrightConfiguration(".*\\.cpp|.*\\.hpp|.*\\.c|.*\\.h|.*\\.java"); > > I would like to see more filetypes included by default. At least `Makefile`, `*.gmk`, `configure`, `*.m4`, `*.md` and `*.properties`. Probably also `*.cc`, `*.hh` and `*.m`. > > We could also consider not defining defaults here and have it all in .jcheck/conf for better visibility. Ah, I didn't think about the default filetypes, just copied from the default of whitespaceConfiguration. I was thinking we can configure it in .jcheck/conf later like the configuration for whitespace check https://github.com/openjdk/jdk/blob/41c8971cbcc1d281ffae907c952637ebff945ebb/.jcheck/conf#L19 ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1872324768 From ihse at openjdk.org Mon Dec 9 22:51:23 2024 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Mon, 9 Dec 2024 22:51:23 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: On Thu, 5 Dec 2024 23:50:21 GMT, Zhao Song wrote: >> jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightConfiguration.java line 29: >> >>> 27: public class CopyrightConfiguration { >>> 28: static final CopyrightConfiguration DEFAULT = >>> 29: new CopyrightConfiguration(".*\\.cpp|.*\\.hpp|.*\\.c|.*\\.h|.*\\.java"); >> >> I would like to see more filetypes included by default. At least `Makefile`, `*.gmk`, `configure`, `*.m4`, `*.md` and `*.properties`. Probably also `*.cc`, `*.hh` and `*.m`. >> >> We could also consider not defining defaults here and have it all in .jcheck/conf for better visibility. > > Ah, I didn't think about the default filetypes, just copied from the default of whitespaceConfiguration. I was thinking we can configure it in .jcheck/conf later like the configuration for whitespace check https://github.com/openjdk/jdk/blob/41c8971cbcc1d281ffae907c952637ebff945ebb/.jcheck/conf#L19 I definitely agree that file patterns that should be checked should be defined in .jcheck/conf. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1872822578 From kcr at openjdk.org Mon Dec 9 22:51:23 2024 From: kcr at openjdk.org (Kevin Rushforth) Date: Mon, 9 Dec 2024 22:51:23 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: On Fri, 6 Dec 2024 08:40:14 GMT, Magnus Ihse Bursie wrote: >> Ah, I didn't think about the default filetypes, just copied from the default of whitespaceConfiguration. I was thinking we can configure it in .jcheck/conf later like the configuration for whitespace check https://github.com/openjdk/jdk/blob/41c8971cbcc1d281ffae907c952637ebff945ebb/.jcheck/conf#L19 > > I definitely agree that file patterns that should be checked should be defined in .jcheck/conf. I also think it would be better to not have any defaults and just define the patterns in `.jcheck/conf` ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1873174439 From zsong at openjdk.org Mon Dec 9 22:51:23 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 9 Dec 2024 22:51:23 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: On Fri, 6 Dec 2024 11:47:18 GMT, Kevin Rushforth wrote: >> I definitely agree that file patterns that should be checked should be defined in .jcheck/conf. > > I also think it would be better to not have any defaults and just define the patterns in `.jcheck/conf` Yes, I discussed with Erik offline yesterday, and we agreed on removing the default setting for this check. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1873691093 From zsong at openjdk.org Mon Dec 9 22:56:11 2024 From: zsong at openjdk.org (Zhao Song) Date: Mon, 9 Dec 2024 22:56:11 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 22:51:22 GMT, Zhao Song wrote: >> This patch introduces a copyright jcheck. >> For pull requests, the check checks the copyright header in all modified files(if the file name matches the regex in .jcheck/conf) > > Zhao Song has updated the pull request incrementally with four additional commits since the last revision: > > - add copyright header > - version 2 > - update > - review comment It's my PR for testing https://github.com/openjdk/playground/pull/224 It's the .jcheck/conf for testing https://github.com/openjdk/playground/blob/testSKARA/.jcheck/conf ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2529708864 From darcy at openjdk.org Mon Dec 9 23:03:30 2024 From: darcy at openjdk.org (Joe Darcy) Date: Mon, 9 Dec 2024 23:03:30 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck In-Reply-To: References: Message-ID: On Thu, 5 Dec 2024 23:23:48 GMT, Zhao Song wrote: > From looking over the logic, I think some additional accommodations will be needed, at least for update trains. For example, if a patch from a feature release authored in 2022 is backported unchanged to an update release, the affected files should have a copyright year end date of 2022 and _not_ 2024. PS FWIW, some related thoughts on automating checks of copyrights and licenses: https://mail.openjdk.org/pipermail/core-libs-dev/2024-December/137090.html ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2529719238 From erikj at openjdk.org Tue Dec 10 13:55:42 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 10 Dec 2024 13:55:42 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: On Fri, 6 Dec 2024 08:41:31 GMT, Magnus Ihse Bursie wrote: >> jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightCheck.java line 67: >> >>> 65: var copyrightFound = false; >>> 66: for (String line : lines) { >>> 67: if (line.contains("Copyright (c)") && line.contains("Oracle")) { >> >> I think it would be nice if we could work with pairs of regular expressions. One for identifying a line that should match and one that verifies the format. This way we could make it possible to add more variants through configuration. >> >> We could also consider not having any default and put the Oracle config in .jcheck/conf. > > I'm not sure its better to have Oracle in the configuration file. It kind of just highlights it as a special case. If/when some other company requests special copyright checks, then we can generalize and move it to the configuration file. Also, it's never the case that this is just a per-repo setting: for Oracle-copyrighted code, this rule always applies. I don't want defaults because once we set them, we have to live with them. Changing the default configuration is risky as it applies globally to all commits that have already been checked as well. I think it's generally a better design having the configuration in the affected repo for increased transparency on what is actually being checked. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878137052 From erikj at openjdk.org Tue Dec 10 14:18:44 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 10 Dec 2024 14:18:44 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 22:51:22 GMT, Zhao Song wrote: >> This patch introduces a copyright format jcheck. >> For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >> >> To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. >> >> For example, if we want to enable a copyright format check for oracle. >> We can define the configuration like this >> >> oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. >> oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. >> oracle_required=true > > Zhao Song has updated the pull request incrementally with four additional commits since the last revision: > > - add copyright header > - version 2 > - update > - review comment cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java line 332: > 330: public void visit(CopyrightFormatIssue i) { > 331: if (!ignore.contains(i.check().name()) && !isLax) { > 332: if (!i.filesWithCopyrightFormatIssue().isEmpty()) { No need to check empty since we are iterating over it anyway. It doesn't hurt to do it, but I think it's more readable without the extra if statement. jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightFormatCheck.java line 52: > 50: return iterator(); > 51: } > 52: var pattern = Pattern.compile(copyrightConf.files()); Could use a more descriptive name. Suggestion: var filesPattern = Pattern.compile(copyrightConf.files()); jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightFormatCheck.java line 53: > 51: } > 52: var pattern = Pattern.compile(copyrightConf.files()); > 53: var copyrightSingleCheckConfigurations = copyrightConf.singleCheckConfigurations(); This variable name is very long. How about just `copyrightConfigs`? jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightFormatCheck.java line 88: > 86: } > 87: } catch (IOException e) { > 88: throw new RuntimeException(e); I would suggest throwing `UncheckedIOException` instead. jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightSingleCheckConfiguration.java line 27: > 25: import java.util.regex.Pattern; > 26: > 27: public class CopyrightSingleCheckConfiguration { Maybe move this to an inner class of `CopyrightFormatConfiguration` and shorten the name to something more manageable? ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878154655 PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878160128 PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878163519 PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878167515 PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878177156 From zsong at openjdk.org Tue Dec 10 18:54:49 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 10 Dec 2024 18:54:49 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v2] In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 14:02:49 GMT, Erik Joelsson wrote: >> Zhao Song has updated the pull request incrementally with four additional commits since the last revision: >> >> - add copyright header >> - version 2 >> - update >> - review comment > > cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java line 332: > >> 330: public void visit(CopyrightFormatIssue i) { >> 331: if (!ignore.contains(i.check().name()) && !isLax) { >> 332: if (!i.filesWithCopyrightFormatIssue().isEmpty()) { > > No need to check empty since we are iterating over it anyway. It doesn't hurt to do it, but I think it's more readable without the extra if statement. Yes, fixed it ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878653668 From zsong at openjdk.org Tue Dec 10 20:36:12 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 10 Dec 2024 20:36:12 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v3] In-Reply-To: References: Message-ID: > This patch introduces a copyright format jcheck. > For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) > > To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. > > For example, if we want to enable a copyright format check for oracle. > We can define the configuration like this > > oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. > oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. > oracle_required=true Zhao Song has updated the pull request incrementally with one additional commit since the last revision: review comment ------------- Changes: - all: https://git.openjdk.org/skara/pull/1702/files - new: https://git.openjdk.org/skara/pull/1702/files/33bd7217..2e639463 Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1702&range=02 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1702&range=01-02 Stats: 110 lines in 5 files changed: 35 ins; 50 del; 25 mod Patch: https://git.openjdk.org/skara/pull/1702.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1702/head:pull/1702 PR: https://git.openjdk.org/skara/pull/1702 From erikj at openjdk.org Tue Dec 10 20:58:31 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 10 Dec 2024 20:58:31 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v3] In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 20:36:12 GMT, Zhao Song wrote: >> This patch introduces a copyright format jcheck. >> For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >> >> To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. >> >> For example, if we want to enable a copyright format check for oracle. >> We can define the configuration like this >> >> oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. >> oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. >> oracle_required=true > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > review comment jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightFormatConfiguration.java line 33: > 31: public class CopyrightFormatConfiguration { > 32: > 33: public static class CopyrightConfiguration { Did you consider making this a record? Looks like a good fit. ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878840860 From zsong at openjdk.org Tue Dec 10 21:36:32 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 10 Dec 2024 21:36:32 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: References: Message-ID: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> > This patch introduces a copyright format jcheck. > For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) > > To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. > > For example, if we want to enable a copyright format check for oracle. > We can define the configuration like this > > oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. > oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. > oracle_required=true Zhao Song has updated the pull request incrementally with one additional commit since the last revision: make CopyrightConfiguration a record ------------- Changes: - all: https://git.openjdk.org/skara/pull/1702/files - new: https://git.openjdk.org/skara/pull/1702/files/2e639463..e1ee94d6 Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1702&range=03 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1702&range=02-03 Stats: 31 lines in 1 file changed: 0 ins; 22 del; 9 mod Patch: https://git.openjdk.org/skara/pull/1702.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1702/head:pull/1702 PR: https://git.openjdk.org/skara/pull/1702 From zsong at openjdk.org Tue Dec 10 21:36:32 2024 From: zsong at openjdk.org (Zhao Song) Date: Tue, 10 Dec 2024 21:36:32 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v3] In-Reply-To: References: Message-ID: <07VlEhN_6pCFNAeyoPd8RDKbV3wJ1XKqGhtVo7MGqp4=.bfb3f089-9bb7-4460-b156-695247e3a1f5@github.com> On Tue, 10 Dec 2024 20:53:37 GMT, Erik Joelsson wrote: >> Zhao Song has updated the pull request incrementally with one additional commit since the last revision: >> >> review comment > > jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightFormatConfiguration.java line 33: > >> 31: public class CopyrightFormatConfiguration { >> 32: >> 33: public static class CopyrightConfiguration { > > Did you consider making this a record? Looks like a good fit. Yes, it makes sense. I have made it a record ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878883981 From erikj at openjdk.org Tue Dec 10 22:41:49 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Tue, 10 Dec 2024 22:41:49 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> Message-ID: <59J9R51JOcCrnwnGumy8xYFytwuAV4MZQdIUYd9GdqM=.d625d915-7490-41ff-9503-9c3aede4405d@github.com> On Tue, 10 Dec 2024 21:36:32 GMT, Zhao Song wrote: >> This patch introduces a copyright format jcheck. >> For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >> >> To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. >> >> For example, if we want to enable a copyright format check for oracle. >> We can define the configuration like this >> >> oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. >> oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. >> oracle_required=true > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > make CopyrightConfiguration a record Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1702#pullrequestreview-2493832671 From zsong at openjdk.org Wed Dec 11 18:19:41 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 11 Dec 2024 18:19:41 GMT Subject: RFR: 1357: Add Oracle copyright header format check to jcheck [v4] In-Reply-To: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> References: <-dcuiv3pEh2r-M3-LjaEdGmM4N3LqPy5tIqMbx_7CiQ=.ba14434c-f996-4ae6-95eb-3ed807715581@github.com> Message-ID: On Tue, 10 Dec 2024 21:36:32 GMT, Zhao Song wrote: >> This patch introduces a copyright format jcheck. >> For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) >> >> To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. >> >> For example, if we want to enable a copyright format check for oracle. >> We can define the configuration like this >> >> oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. >> oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. >> oracle_required=true > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > make CopyrightConfiguration a record Thank you all for comments and reviews! ------------- PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2536785252 From zsong at openjdk.org Wed Dec 11 18:19:41 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 11 Dec 2024 18:19:41 GMT Subject: Integrated: 1357: Add Oracle copyright header format check to jcheck In-Reply-To: References: Message-ID: On Thu, 5 Dec 2024 22:43:08 GMT, Zhao Song wrote: > This patch introduces a copyright format jcheck. > For pull requests, this check checks the format of copyright header in all modified files(if the file name matches the regex in .jcheck/conf) > > To enable the new copyrightFormat jcheck, proper configurations are needed in .jcheck/conf. A locator, a validator are needed in the .jcheck/conf file. The locator is only used to locate the copyright line, so the regex is easier to match. If the locator could find the copyright line, then validator will be used to validate the format of the line. There is also an optional parameter "required", it indicates whether a copyright is required for each file, if true, the check will fail if the copyright is missing. > > For example, if we want to enable a copyright format check for oracle. > We can define the configuration like this > > oracle_locator=.*Copyright (c)(.*)Oracle and/or its affiliates. All rights reserved. > oracle_validator=.*Copyright (c) (\d{4})(?:, (\d{4}))?, Oracle and/or its affiliates. All rights reserved. > oracle_required=true This pull request has now been integrated. Changeset: 67b91555 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/67b91555ad5f74651a8cc0199bc82366d269d1f8 Stats: 490 lines in 12 files changed: 481 ins; 0 del; 9 mod 1357: Add Oracle copyright header format check to jcheck Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1702 From zsong at openjdk.org Wed Dec 11 21:09:56 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 11 Dec 2024 21:09:56 GMT Subject: RFR: 2424: Enable copyright format check Message-ID: Enable copyright check for skara ------------- Commit messages: - SKARA-2424 Changes: https://git.openjdk.org/skara/pull/1703/files Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1703&range=00 Issue: https://bugs.openjdk.org/browse/SKARA-2424 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1703.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1703/head:pull/1703 PR: https://git.openjdk.org/skara/pull/1703 From zsong at openjdk.org Wed Dec 11 21:12:15 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 11 Dec 2024 21:12:15 GMT Subject: RFR: 2424: Enable copyright format check In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 20:09:18 GMT, Zhao Song wrote: > Enable copyright check for skara .jcheck/conf line 32: > 30: [checks] > 31: error=author,reviewers,whitespace > 32: warning=copyright I am not sure if we should make it an error or warning. Maybe warning first and later we can change it to error ------------- PR Review Comment: https://git.openjdk.org/skara/pull/1703#discussion_r1881004619 From zsong at openjdk.org Wed Dec 11 22:25:43 2024 From: zsong at openjdk.org (Zhao Song) Date: Wed, 11 Dec 2024 22:25:43 GMT Subject: RFR: 2424: Enable copyright format check [v2] In-Reply-To: References: Message-ID: <1ZKhHI4hDSK21zQBHFYcXcedKPgHGW0j3mcDJehlgF4=.e43393ea-163e-4106-bb3d-8d6b54725c91@github.com> > Enable copyright check for skara Zhao Song has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/skara/pull/1703/files - new: https://git.openjdk.org/skara/pull/1703/files/8e4cfd8e..629f2ef8 Webrevs: - full: https://webrevs.openjdk.org/?repo=skara&pr=1703&range=01 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1703&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/skara/pull/1703.diff Fetch: git fetch https://git.openjdk.org/skara.git pull/1703/head:pull/1703 PR: https://git.openjdk.org/skara/pull/1703 From erikj at openjdk.org Thu Dec 12 14:01:18 2024 From: erikj at openjdk.org (Erik Joelsson) Date: Thu, 12 Dec 2024 14:01:18 GMT Subject: RFR: 2424: Enable copyright format check [v2] In-Reply-To: <1ZKhHI4hDSK21zQBHFYcXcedKPgHGW0j3mcDJehlgF4=.e43393ea-163e-4106-bb3d-8d6b54725c91@github.com> References: <1ZKhHI4hDSK21zQBHFYcXcedKPgHGW0j3mcDJehlgF4=.e43393ea-163e-4106-bb3d-8d6b54725c91@github.com> Message-ID: <7mXJcIMjARPqvWoVA_a1rmuFdikYmzZEsyqTJhgYMwY=.8ee7a731-c24c-4bb7-88d9-fa2abc4d97ee@github.com> On Wed, 11 Dec 2024 22:25:43 GMT, Zhao Song wrote: >> Enable copyright check for skara > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > update Marked as reviewed by erikj (Lead). ------------- PR Review: https://git.openjdk.org/skara/pull/1703#pullrequestreview-2499723490 From zsong at openjdk.org Thu Dec 12 16:44:31 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 12 Dec 2024 16:44:31 GMT Subject: RFR: 2424: Enable copyright format check [v2] In-Reply-To: <1ZKhHI4hDSK21zQBHFYcXcedKPgHGW0j3mcDJehlgF4=.e43393ea-163e-4106-bb3d-8d6b54725c91@github.com> References: <1ZKhHI4hDSK21zQBHFYcXcedKPgHGW0j3mcDJehlgF4=.e43393ea-163e-4106-bb3d-8d6b54725c91@github.com> Message-ID: On Wed, 11 Dec 2024 22:25:43 GMT, Zhao Song wrote: >> Enable copyright check for skara > > Zhao Song has updated the pull request incrementally with one additional commit since the last revision: > > update Thank you for the review! ------------- PR Comment: https://git.openjdk.org/skara/pull/1703#issuecomment-2539465934 From zsong at openjdk.org Thu Dec 12 16:44:31 2024 From: zsong at openjdk.org (Zhao Song) Date: Thu, 12 Dec 2024 16:44:31 GMT Subject: Integrated: 2424: Enable copyright format check In-Reply-To: References: Message-ID: <9thMpBxQLcH7zg3tSeUkkplrjadE7Gv0YwtnvykCRtc=.aeee3aea-e8f2-4546-9166-2dd8c066655e@github.com> On Wed, 11 Dec 2024 20:09:18 GMT, Zhao Song wrote: > Enable copyright check for skara This pull request has now been integrated. Changeset: b62f15d7 Author: Zhao Song URL: https://git.openjdk.org/skara/commit/b62f15d7e6b10c142ee44ba5f5f9bbaf206f153c Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod 2424: Enable copyright format check Reviewed-by: erikj ------------- PR: https://git.openjdk.org/skara/pull/1703