RFR: 2420: Remove closed pr from all entries in targetRefPRMap

[Erik Joelsson]

On Wed, 4 Dec 2024 19:57:10 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In [SKARA-1937](https://bugs.openjdk.org/browse/SKARA-1937), we introduced a feature that pull request bot can re-evaluate all PRs when jcheck configuration changes. When implementing it, I let pull request bot maintains a hash map called targetRefPRMap. The key is the name of targetRef and the value is the list of pr which targets to the targetRef. Currently, when a pr is closed, the bot will unlink it with its current targetRef. There was an issue happened recently, there was an entry {pr/96=[pr/97]} in the hash map, and before pr/97 was integrated, the user retargeted the pr from pr/96 to master, so the bot fails to remove the association between pr/96 and pr/97.
> 
> I think the right behavior here is that when pull request bot finds an updated pr, it should unlink this pr with all targetRefs and if this pr is still open, the bot should link the pr with current targetRef.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java line 241:

> 239:                 }
> 240:             } catch (UncheckedRestException e) {
> 241:                 if (e.getStatusCode() != 404) {

Suggestion:

                // If the targetRef is invalid, fileContents() will throw a 404 instead of returning
                // empty. In this case we should ignore this and continue processing other PRs.
                // Any invalid refs will get removed from targetRefMap in the next round.
                if (e.getStatusCode() != 404) {

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1701#discussion_r1870452185