Integrated: 2420: Remove closed pr from all entries in targetRefPRMap

[Zhao Song]

On Wed, 4 Dec 2024 19:57:10 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In [SKARA-1937](https://bugs.openjdk.org/browse/SKARA-1937), we introduced a feature that pull request bot can re-evaluate all PRs when jcheck configuration changes. When implementing it, I let pull request bot maintains a hash map called targetRefPRMap. The key is the name of targetRef and the value is the list of pr which targets to the targetRef. Currently, when a pr is closed, the bot will unlink it with its current targetRef. There was an issue happened recently, there was an entry {pr/96=[pr/97]} in the hash map, and before pr/97 was integrated, the user retargeted the pr from pr/96 to master, so the bot fails to remove the association between pr/96 and pr/97.
> 
> I think the right behavior here is that when pull request bot finds an updated pr, it should unlink this pr with all targetRefs and if this pr is still open, the bot should link the pr with current targetRef.

This pull request has now been integrated.

Changeset: c13468d8
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/c13468d89f90efd51ca8f89e500eb59a1c7855e4
Stats:     44 lines in 5 files changed: 25 ins; 5 del; 14 mod

2420: Remove closed pr from all entries in targetRefPRMap

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1701