RFR: 1357: Add Oracle copyright header format check to jcheck

Zhao Song zsong at openjdk.org
Thu Dec 5 23:25:58 UTC 2024


On Thu, 5 Dec 2024 22:43:08 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch introduces a copyright jcheck.
> For pull requests, the check checks the copyright header in all modified files(if the file name matches the regex in .jcheck/conf)

> From looking over the logic, I think some additional accommodations will be needed, at least for update trains. For example, if a patch from a feature release authored in 2022 is backported unchanged to an update release, the affected files should have a copyright year end date of 2022 and _not_ 2024.

You're right, maybe this is why Erik said "not make any attempt at verifying that files have the correct header, or that the copyright years are correct" in the issue description

-------------

PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2521708951


More information about the skara-dev mailing list