RFR: 1357: Add Oracle copyright header format check to jcheck
Erik Joelsson
erikj at openjdk.org
Thu Dec 5 23:28:37 UTC 2024
On Thu, 5 Dec 2024 22:43:08 GMT, Zhao Song <zsong at openjdk.org> wrote:
> This patch introduces a copyright jcheck.
> For pull requests, the check checks the copyright header in all modified files(if the file name matches the regex in .jcheck/conf)
>From the bug description:
> Note that this feature is only about verifying the format of Oracle copyright headers. It will, for example, not make any attempt at verifying that files have the correct header, or that the copyright years are correct. These are things that need human inspection.
We have a pretty well established agreement from discussing this feature over the years that we should not try to automate copyright year values. The copyright year should only be updated if a "significant" change is made to the copyrighted material. Because of this it's a judgement call each time a file is edited. The issue Joe brings up also makes it hard to automate. We simply don't have the information about when the copyrighted material was created.
-------------
PR Comment: https://git.openjdk.org/skara/pull/1702#issuecomment-2521712730
More information about the skara-dev
mailing list