RFR: 1357: Add Oracle copyright header format check to jcheck [v2]

Kevin Rushforth kcr at openjdk.org
Mon Dec 9 22:51:23 UTC 2024


On Fri, 6 Dec 2024 08:40:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Ah, I didn't think about the default filetypes, just copied from the default of whitespaceConfiguration. I was thinking we can configure it in .jcheck/conf later like the configuration for  whitespace check https://github.com/openjdk/jdk/blob/41c8971cbcc1d281ffae907c952637ebff945ebb/.jcheck/conf#L19
>
> I definitely agree that file patterns that should be checked should be defined in .jcheck/conf.

I also think it would be better to not have any defaults and just define the patterns in `.jcheck/conf`

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1873174439


More information about the skara-dev mailing list