RFR: 1357: Add Oracle copyright header format check to jcheck [v2]

[Zhao Song]

On Tue, 10 Dec 2024 14:02:49 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - add copyright header
>>  - version 2
>>  - update
>>  - review comment
>
> cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java line 332:
> 
>> 330:     public void visit(CopyrightFormatIssue i) {
>> 331:         if (!ignore.contains(i.check().name()) && !isLax) {
>> 332:             if (!i.filesWithCopyrightFormatIssue().isEmpty()) {
> 
> No need to check empty since we are iterating over it anyway. It doesn't hurt to do it, but I think it's more readable without the extra if statement.

Yes, fixed it

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878653668