RFR: 1357: Add Oracle copyright header format check to jcheck [v3]

Zhao Song zsong at openjdk.org
Tue Dec 10 21:36:32 UTC 2024


On Tue, 10 Dec 2024 20:53:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment
>
> jcheck/src/main/java/org/openjdk/skara/jcheck/CopyrightFormatConfiguration.java line 33:
> 
>> 31: public class CopyrightFormatConfiguration {
>> 32: 
>> 33:     public static class CopyrightConfiguration {
> 
> Did you consider making this a record? Looks like a good fit.

Yes, it makes sense. I have made it a record

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1702#discussion_r1878883981


More information about the skara-dev mailing list