RFR: 2167: Unify search methods in IssueProject [v2]

[Erik Joelsson]

On Mon, 12 Feb 2024 15:02:45 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> this patch unifies the various ways of searching that exist within `JiraProejct`. I also chose to expose the `search` method in the `IssueProject` since I will make use of it in later patches. This is the first patch of _many_ that will extract the JBS specific parts from `JiraProject` so that `JiraProject` will be about JIRA and JBS specific functionality will be moved elsewhere. This refactoring is needed to allow other parts of the Skara to use JBS functionality with only an `IssueProject` instance (without turning `JiraProject` into effectively `JbsProject`).
>> 
>> Thanks,
>> Erik
>
> Erik Duveblad has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - update JiraProject::search
>  - Do not expose the "search" method

issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java line 522:

> 520:             }
> 521: 
> 522:             if (count < issues.get("total").asInt() && count < limit) {

If `limit == -1` then we will never try to request more pages. Is that intended?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1610#discussion_r1486595794