RFR: 2167: Unify search methods in IssueProject [v3]
Erik Joelsson
erikj at openjdk.org
Tue Feb 13 18:56:51 UTC 2024
On Tue, 13 Feb 2024 13:51:33 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:
>> Hi all,
>>
>> this patch unifies the various ways of searching that exist within `JiraProejct`. I also chose to expose the `search` method in the `IssueProject` since I will make use of it in later patches. This is the first patch of _many_ that will extract the JBS specific parts from `JiraProject` so that `JiraProject` will be about JIRA and JBS specific functionality will be moved elsewhere. This refactoring is needed to allow other parts of the Skara to use JBS functionality with only an `IssueProject` instance (without turning `JiraProject` into effectively `JbsProject`).
>>
>> Thanks,
>> Erik
>
> Erik Duveblad has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix limit
This looks like it's doing the right thing. It would be good if you could add a manual test that verifies that it at least doesn't blow up, similar to existing manual tests for API calls.
-------------
PR Review: https://git.openjdk.org/skara/pull/1610#pullrequestreview-1878710103
More information about the skara-dev
mailing list