Integrated: 2176: Repository.fetch should return an Optional<Hash>

Erik Duveblad ehelin at openjdk.org
Tue Feb 20 17:07:11 UTC 2024


On Mon, 19 Feb 2024 14:01:33 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `Repository.fetch` return an `Optional<Hash>` instead of just a `Hash` (since a `fetch` operation might now always fetch a commit, for example if code is trying to fetch a ref that does not exist in the remote repo). A fairly large diff, but I just moved the `.orElseThrow` one frame up in the call chain, so now the caller decides whether it should do `.orElseThrow` (instread of the callee, in this case `fetch`).
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 301d61f0
Author:    Erik Duveblad <ehelin at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/301d61f075b2f8e6d97f0eb43c62ba7fe2459739
Stats:     85 lines in 37 files changed: 0 ins; 3 del; 82 mod

2176: Repository.fetch should return an Optional<Hash>

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1613


More information about the skara-dev mailing list