RFR: 2168: Don't preserve invalid local clone

[Erik Joelsson]

On Mon, 26 Feb 2024 23:08:24 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When skara bot is running, it frequently clones a lot of repos to the local machine and sometimes, the clone would be invalid due to various reasons.
> 
> Currently, if the skara bot found an invalid local clone, it will preserve the invalid clone by renaming it. ErikJ said the original authors might want to do some investigations on the invalid clones, so they chose to preserve the invalid clone.
> 
> But now, we rarely investigate the clones. And as time goes by, the local machine running skara will have more and more invalid clones and the disk usage will be very high. And skara admin will need to clean the invalid repos periodically.
> 
> To fix this issue, we should just clear the invalid repo in HostedRepositoryPool#removeOldClone.

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1615#pullrequestreview-1902244013