RFR: 2131: Make second jcheck run work on merge-style PR

Wed Jan 3 13:40:10 UTC 2024

On Tue, 2 Jan 2024 22:00:43 GMT, Zhao Song <zsong at openjdk.org> wrote:

> When testing [SKARA-2115](https://bugs.openjdk.org/browse/SKARA-2115), I find that if we change the jcheck conf in the source branch of a merge style PR. The pr will NOT run jcheck against the localJCheckConf(merged conf of source and target JCheckConf).
> After investigation, I realized that this bug exists since the first time we introduced the second jcheck run feature. This bug was partly fixed by introducing IsJCheckConfUpdatedInMergePR.
> However, IsJCheckConfUpdatedInMergePR will only be set correctly when workItem.bot.jcheckMerge() is true.
> To fix it, we should set isJCheckConfUpdatedInMergePR correctly when the PR is a merge-style PR.

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1595#pullrequestreview-1802087435