RFR: 2141: Inform user about accepting fork repo invite in /backport command reply

Erik Joelsson erikj at openjdk.org
Thu Jan 11 22:51:06 UTC 2024


On Thu, 11 Jan 2024 20:30:47 GMT, Zhao Song <zsong at openjdk.org> wrote:

> After users issued /backport command to create backport PRs in GitHub, skara bot will invite the users to be collaborators of the bot's fork. Sometimes, the users will ignore the invitation and later when they are trying to update the backport branch, they will find they don't have the access. This patch is trying to add a comment to remind the user to accept the invitation.

I just realized that we have the `fork.canPush` check further up. We could make this comment conditional on that as well. If the user already has push permission, we don't need to remind them of this.

In this case, we should change the message a bit.

-------------

PR Review: https://git.openjdk.org/skara/pull/1598#pullrequestreview-1816962348


More information about the skara-dev mailing list