RFR: 2141: Inform user about accepting fork repo invite in /backport command reply
Erik Joelsson
erikj at openjdk.org
Thu Jan 11 22:54:21 UTC 2024
On Thu, 11 Jan 2024 20:30:47 GMT, Zhao Song <zsong at openjdk.org> wrote:
> After users issued /backport command to create backport PRs in GitHub, skara bot will invite the users to be collaborators of the bot's fork. Sometimes, the users will ignore the invitation and later when they are trying to update the backport branch, they will find they don't have the access. This patch is trying to add a comment to remind the user to accept the invitation.
bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 418:
> 416: reply.print(" ");
> 417: reply.print("If this is the first time you are using the /backport command for this particular target repository, " +
> 418: "a `collaborator` invite will be sent out for my fork [" + fork.name() + "](" + fork.url() + "). You will need to accept this invite before you can proceed.\n");
If we only print this when the user doesn't have push permission, the message should be something like this instead:
"You are not yet a collaborator in my fork (name). An invite will be sent out and you need to accept it before you can proceed."
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1598#discussion_r1449490575
More information about the skara-dev
mailing list