RFR: 2152: Use full name for tags if possible

Erik Duveblad ehelin at openjdk.org
Mon Jan 22 08:57:57 UTC 2024


On Fri, 19 Jan 2024 14:05:21 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that makes the `/tag` commit command use the user's full name (if possible) for the author and committer name field for the Git tag it creates. This is the same convention we use for the author/committer name and e-mail metadata in the commits (it was just a mistake on my part that `contributor.username()` was used in the original code for the `/tag` commit command).
>> 
>> ### Testing
>> - [x] Added a new unit tests that fails without this patch but passes with it
>> 
>> Thanks,
>> Erik
>
> Marked as reviewed by erikj (Lead).

Thanks @erikj79 and @zhaosongzs for reviewing!

-------------

PR Comment: https://git.openjdk.org/skara/pull/1603#issuecomment-1903524443


More information about the skara-dev mailing list