RFR: 2039: Only post ApprovalNeededComment when the user hasn't applied for maintainer approval for all the issues

Zhao Song zsong at openjdk.org
Fri Jan 26 23:43:15 UTC 2024


On Fri, 26 Jan 2024 23:36:47 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> > > > the bot shouldn't post ApprovalNeededComment if the user already applied for at least one of the issues.
> > > 
> > > 
> > > For multiple issues, should the `ApprovalNeededComment` be posted if one (or more) of the issues is missing the approval request? In that case you would only skip posting the message if _all_ of the issues have the approval request.
> > 
> > 
> > I was thinking post` ApprovalNeededComment` only when all the issues have the request, but later, I think that if there is one issue contains the request, then it means the user knows how to make the request. So no need to post the comment.
> 
> I think I agree with Kevin. If any issue is missing the approval request, post the reminder. The user may have missed one unintentionally.

OK,  I will fix it.

-------------

PR Comment: https://git.openjdk.org/skara/pull/1606#issuecomment-1912832470


More information about the skara-dev mailing list