RFR: 2039: Only post ApprovalNeededComment when the user hasn't applied for maintainer approval for all the issues [v2]

Zhao Song zsong at openjdk.org
Mon Jan 29 22:03:36 UTC 2024


> In [SKARA-1949](https://bugs.openjdk.org/browse/SKARA-1949), we introduced /approval command and at the same time, we let the bot post ApprovalNeededComment when the pull request is reviewed.
> 
> As Kevin Rushforth suggested, the bot shouldn't post ApprovalNeededComment if the user already applied for all the issues.

Zhao Song has updated the pull request incrementally with two additional commits since the last revision:

 - rename
 - update

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1606/files
  - new: https://git.openjdk.org/skara/pull/1606/files/39046995..3291a323

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1606&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1606&range=00-01

  Stats: 18 lines in 2 files changed: 15 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/skara/pull/1606.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1606/head:pull/1606

PR: https://git.openjdk.org/skara/pull/1606


More information about the skara-dev mailing list