RFR: 2039: Only post ApprovalNeededComment when the user hasn't applied for maintainer approval for all the issues [v2]

Erik Joelsson erikj at openjdk.org
Tue Jan 30 13:56:51 UTC 2024


On Mon, 29 Jan 2024 22:03:36 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In [SKARA-1949](https://bugs.openjdk.org/browse/SKARA-1949), we introduced /approval command and at the same time, we let the bot post ApprovalNeededComment when the pull request is reviewed.
>> 
>> As Kevin Rushforth suggested, the bot shouldn't post ApprovalNeededComment if the user already applied for all the issues.
>
> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - rename
>  - update

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1606#pullrequestreview-1851341203


More information about the skara-dev mailing list