Integrated: 2039: Only post ApprovalNeededComment when the user hasn't applied for maintainer approval for all the issues

Zhao Song zsong at openjdk.org
Tue Jan 30 18:49:28 UTC 2024


On Fri, 26 Jan 2024 20:06:33 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In [SKARA-1949](https://bugs.openjdk.org/browse/SKARA-1949), we introduced /approval command and at the same time, we let the bot post ApprovalNeededComment when the pull request is reviewed.
> 
> As Kevin Rushforth suggested, the bot shouldn't post ApprovalNeededComment if the user already applied for all the issues.

This pull request has now been integrated.

Changeset: 4e9dad2b
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/4e9dad2b03fa963f4a302c1e82b77e9d347330f2
Stats:     45 lines in 3 files changed: 28 ins; 13 del; 4 mod

2039: Only post ApprovalNeededComment when the user hasn't applied for maintainer approval for all the issues

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1606


More information about the skara-dev mailing list