RFR: 2304: /backport jdk23 should provide a more helpful message [v2]
Zhao Song
zsong at openjdk.org
Wed Jul 3 17:20:10 UTC 2024
On Wed, 3 Jul 2024 06:50:20 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java
>>
>> Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>> - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java
>>
>> Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 208:
>
>> 206: reply.println();
>> 207: }
>> 208: reply.println("The target repository `" + repoNameArg + "` is not a valid target for backports. ");
>
> I think this line should be first in the message, then followed by the branch message if there is a branch match.
Sure, will fix it
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1667#discussion_r1664520914
More information about the skara-dev
mailing list