RFR: 2292: Improve the labels of Review/Commit links for backport branches

[Zhao Song]

On Fri, 5 Jul 2024 22:23:48 GMT, Zhao Song <zsong at openjdk.org> wrote:

> The patch is trying to add a branch name to the commit link, review link, commit comment, review comment in JBS.
> 
> Adding a branch name for commit link and comment is feasible and easy, but adding a branch name for review link and review comment is not that easy because people can retarget pull request. Therefore, the bot needs to save the target branch name in the storage.
> 
> I believe my patch will be compatible with the existing storage files.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/PullRequestWorkItem.java line 140:

> 138:                                 if (pr.targetBranch() != null) {
> 139:                                     ret.put("targetBranch", JSON.of(pr.targetBranch()));
> 140:                                 }

We have two options for handling non-replaced entries:
1: Do not add a null JSON for targetBranch
2: Add a null JSON for targetBranch

Currently, I chose option 1

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1671#discussion_r1667191910