RFR: 2312: Do not require re-review for a simple merge

Pavel Rappo prappo at openjdk.org
Mon Jul 8 14:58:41 UTC 2024


If a repository is configured to ignore stale reviews, every commit to a PR made against that repo means that the PR needs to be re-reviewed. Re-reviewing is costly, and not all commits are worth that cost.

One example of such a commit is a simple merge. During a PR's lifetime, the PR's target branch (typically, repo's `master`) might be merged into the PR multiple times. Usually, such merges are trivial and would effectively be performed by Skara automatically if the PR didn't have them in the first place [^*]. For such commits, it makes sense to not require review.

This is my first contribution to Skara domain logic, which I've just started learning about. Also, while I tried to code this change according to Skara customs and idioms, I might have missed something. I guess what I'm saying is **take extra care** reviewing this PR. Thanks.


[^*]: This is the main assumption of this PR. Any simple merges present in a PR change the end result of that PR insignificantly, if at all.

-------------

Commit messages:
 - Initial commit

Changes: https://git.openjdk.org/skara/pull/1672/files
  Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1672&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-2312
  Stats: 436 lines in 11 files changed: 413 ins; 7 del; 16 mod
  Patch: https://git.openjdk.org/skara/pull/1672.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1672/head:pull/1672

PR: https://git.openjdk.org/skara/pull/1672


More information about the skara-dev mailing list