RFR: 2312: Do not require re-review for a simple merge [v2]

Zhao Song zsong at openjdk.org
Tue Jul 9 00:10:21 UTC 2024


On Mon, 8 Jul 2024 23:19:08 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java line 1012:
>> 
>>> 1010:         }
>>> 1011:     }
>>> 1012: 
>> 
>> Maybe it's better to add an interface in `ReadOnlyRepository`
>
> If we add this method to `ReadOnlyRepository`, then we'll need to provide some implementation of it for `HgRepository`, which is a subclass of `ReadOnlyRepository`. Not only does `HgRepository` need no such functionality (AFAIK, PRs are not modelled to work in Mercurial repos), a Mercurial implementation will likely be more involved than that of Git.

Yes, for `HgRepository`,  you just need to put `throw new UnsupportedOperationException();` in the implementation

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1672#discussion_r1669465951


More information about the skara-dev mailing list