RFR: 2312: Do not require re-review for a simple merge [v2]

Pavel Rappo prappo at openjdk.org
Tue Jul 9 00:34:20 UTC 2024


On Tue, 9 Jul 2024 00:23:34 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Naming is hard. Consistent naming in an established project is harder still.
>> 
>> `includeSimpleMerges` (or whatever it ends up being named) is supposed to work in pair with `ignoreStaleReviews`. In that pair, "include" is the opposite to "ignore": do not ignore reviews for simple merges.
>> 
>> That said, I'm open to better naming.
>
> So you said `includeSimpleMerges` means "do not ignore reviews for simple merges."?

Yes.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1672#discussion_r1669481103


More information about the skara-dev mailing list