RFR: 2312: Do not require re-review for a simple merge [v4]

[Pavel Rappo]

On Tue, 9 Jul 2024 09:27:06 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Just the other day, we reflected over that config option when we enabled it for the mainline jdk repository as it could be interpreted both ways, but we agreed that the opposite interpretation was our instinctive assumption.

When I started this work, I was surprised to realise that `ignoreStaleReviews` is true means that outdated reviews are **not** included in the total count of reviews. Like you said, it's counterintuitive.

But I didn't propose to change it because it's an established property that some repos already use. So, like you said, if we change it, we should be prepared to change the configuration of the affected repos too.

Those names you suggested, are they both for JSON configuration and Java code? In other words, should I change code like this?

            if (repo.value().contains("useStaleReviews")) {
                botBuilder.useStaleReviews(repo.value().get("useStaleReviews").asBoolean());
            }
            if (repo.value().contains("acceptSimpleMerges")) {
                botBuilder.acceptSimpleMerges(repo.value().get("acceptSimpleMerges").asBoolean());
            }

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1672#discussion_r1672005706