RFR: 2312: Do not require re-review for a simple merge [v2]
Pavel Rappo
prappo at openjdk.org
Wed Jul 10 11:31:43 UTC 2024
On Tue, 9 Jul 2024 09:44:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Respond to feedback
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java line 167:
>
>> 165: botBuilder.ignoreStaleReviews(repo.value().get("ignorestale").asBoolean());
>> 166: }
>> 167: if (repo.value().contains("includemerge")) {
>
> In newer Skara code we have already moved towards using camel case in the config options and having them match the boolean in the code, so I think we should do that here too, for both this new option and the old `ignorestale` if we agree to fix both.
I see, that answers my earlier question: https://github.com/openjdk/skara/pull/1672#discussion_r1672005706
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1672#discussion_r1672008592
More information about the skara-dev
mailing list