RFR: 2323: Use stream-bearing methods of java.nio.file.Files correctly

Pavel Rappo prappo at openjdk.org
Wed Jul 10 11:53:50 UTC 2024


On Wed, 10 Jul 2024 10:39:41 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> For the gradle plugins, did you verify building the targets using them?

I'll do all the extra testing I can, but according to my earlier code coverage for the `test` target, the following classes, not all of which are related to Gradle (*), were **insufficiently** covered on the affected lines.

  - org.openjdk.skara.bots.hgbridge.Exporter
  - org.openjdk.skara.bots.merge.MergeBot
  - org.openjdk.skara.cli.debug.GitMlRules
  - org.openjdk.skara.cli.debug.GitVerifyImport
  - org.openjdk.skara.cli.GitTrees
  - org.openjdk.skara.cli.GitWebrev
  - org.openjdk.skara.gradle.images.DownloadJDKTask *
  - org.openjdk.skara.gradle.images.LaunchersTask *
  - org.openjdk.skara.gradle.images.LinkTask *
  - org.openjdk.skara.gradle.version.VersionPlugin *
  - org.openjdk.skara.vcs.git.GitRepository
  - org.openjdk.skara.vcs.hg.HgRepository
  - org.openjdk.skara.vcs.openjdk.convert.HgToGitConverter

Any suggestions for the extra testing?

-------------

PR Comment: https://git.openjdk.org/skara/pull/1675#issuecomment-2220314407


More information about the skara-dev mailing list