Integrated: 2312: Do not require re-review for a simple merge

[Pavel Rappo]

On Mon, 8 Jul 2024 14:55:44 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> If a repository is configured to ignore stale reviews, every commit to a PR made against that repo means that the PR needs to be re-reviewed. Re-reviewing is costly, and not all commits are worth that cost.
> 
> One example of such a commit is a simple merge. During a PR's lifetime, the PR's target branch (typically, repo's `master`) might be merged into the PR multiple times. Usually, such merges are trivial and would effectively be performed by Skara automatically if the PR didn't have them in the first place [^*]. For such commits, it makes sense to not require review.
> 
> This is my first contribution to Skara domain logic, which I've just started learning about. Also, while I tried to code this change according to Skara customs and idioms, I might have missed something. I guess what I'm saying is **take extra care** reviewing this PR. Thanks.
> 
> 
> [^*]: This is the main assumption of this PR. Any simple merges present in a PR change the end result of that PR insignificantly, if at all.

This pull request has now been integrated.

Changeset: 45468cde
Author:    Pavel Rappo <prappo at openjdk.org>
Committer: Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/45468cde2dc5273c70f728c46c6b133e3d16b55a
Stats:     510 lines in 17 files changed: 459 ins; 7 del; 44 mod

2312: Do not require re-review for a simple merge

Reviewed-by: zsong, erikj

-------------

PR: https://git.openjdk.org/skara/pull/1672