RFR: 2326: Don't send the ready for sponsor comment to mailing list if the pr is closed

[David Holmes]

On Thu, 11 Jul 2024 22:13:57 GMT, Zhao Song <zsong at openjdk.org> wrote:

> After we deployed [SKARA-2302](https://bugs.openjdk.org/browse/SKARA-2302) and [SKARA-2322](https://bugs.openjdk.org/browse/SKARA-2322), some users complained about receiving numerous "ready for sponsor" emails from closed PRs.
> We should prevent the bot from retroactively sending out these emails.

bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java line 156:

> 154:         if (bot.ignoredUsers().contains(author.username())) {
> 155:             if (pr.isOpen()) {
> 156:                 return !PullRequestConstants.READY_FOR_SPONSOR_MARKER_PATTERN.matcher(body).find() && pr.isOpen();

You already know `pr.IsOpen()` is true here.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1676#discussion_r1674811729