RFR: 2326: Don't send the ready for sponsor comment to mailing list if the pr is closed [v2]

Zhao Song zsong at openjdk.org
Thu Jul 11 23:54:35 UTC 2024


On Thu, 11 Jul 2024 23:15:23 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment
>
> bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java line 156:
> 
>> 154:         if (bot.ignoredUsers().contains(author.username())) {
>> 155:             if (pr.isOpen()) {
>> 156:                 return !PullRequestConstants.READY_FOR_SPONSOR_MARKER_PATTERN.matcher(body).find() && pr.isOpen();
> 
> You already know `pr.IsOpen()` is true here.

Oh right, thanks

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1676#discussion_r1674829933


More information about the skara-dev mailing list