RFR: 2331: Improve review notes

Chen Liang liach at openjdk.org
Thu Jul 18 12:48:39 UTC 2024


On Thu, 18 Jul 2024 10:52:54 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> There are two variants of a note that can be added to an item in the "Reviewers" list of a PR body:
> 
>   - 🔄 Re-review required ...
>   - ⚠️ Review applies to ...
> 
> That note may confuse or draw unneeded attention to the PR body.
> 
> Firstly, as a result of recently integrated [SKARA-2312][], "⚠️ Review applies to ..." is also added to an item (i.e. review) that applies to the head of the PR. Secondly, "🔄 Re-review required (review applies to ..." may be present for some items even though a PR has the green "ready" label.
> 
> [SKARA-2312]: https://bugs.openjdk.org/browse/SKARA-2312

Can we change the emoji for "outdated review" from ⚠ to something weaker than 🔄, like 🕒?

-------------

PR Comment: https://git.openjdk.org/skara/pull/1679#issuecomment-2236409658


More information about the skara-dev mailing list