RFR: 2331: Improve review notes

[Chen Liang]

On Thu, 18 Jul 2024 10:52:54 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> There are two variants of a note that can be added to an item in the "Reviewers" list of a PR body:
> 
>   - 🔄 Re-review required ...
>   - ⚠️ Review applies to ...
> 
> That note may confuse or draw unneeded attention to the PR body.
> 
> Firstly, as a result of recently integrated [SKARA-2312][], "⚠️ Review applies to ..." is also added to an item (i.e. review) that applies to the head of the PR. Secondly, "🔄 Re-review required (review applies to ..." may be present for some items even though a PR has the green "ready" label.
> 
> [SKARA-2312]: https://bugs.openjdk.org/browse/SKARA-2312

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 616:

> 614:                                                            + "](" + pr.filesUrl(hash.get()) + "))";
> 615:                                                } else {
> 616:                                                    entry += " ⚠️ Review applies to [" + hash.get().abbreviate()

Now that 🔄 and ⚠️ can appear on 2 different reviewers in the same PR, we should consider changing this warning symbol to some other emoji that indicates "outdated".

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1679#discussion_r1683282308