RFR: 2331: Improve review notes

[Pavel Rappo]

On Thu, 18 Jul 2024 17:57:30 GMT, Zhao Song <zsong at openjdk.org> wrote:

> I am not sure if it's a good idea to change the return value of `CheckablePullRequest.executeChecks`.

Why?

> I think you can use `visitor.getChecks()` to determine if reviewers check failed or not.

Keys from `Map<String, Boolean> getChecks()` are to be displayed to an end user; they don't seem to be for programmatic consumption. I shudder when thinking about parsing these:

    "Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))"
    "Change must not contain extraneous whitespace"

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1679#discussion_r1683385172