RFR: 2335: Avoid creating unneeded objects

[Zhao Song]

On Fri, 19 Jul 2024 12:36:57 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> This PR removes needless objects, some of which are resources. Removing those objects should have no effect.

Looks good

vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java line 745:

> 743:         try (var dir = new TemporaryDirectory()) {
> 744:             var r = TestableRepository.init(dir.path(), vcs);
> 745:             assertEquals(List.of(), r.branches());

I am just curious about the expected behavior when testing on a mercurial (hg) repository.

When I initialize a new hg repository and run `hg branch`, it returns "default". However, when I use `hg branches`, it returns empty. So is "default" branch ignored?

-------------

Marked as reviewed by zsong (Reviewer).

PR Review: https://git.openjdk.org/skara/pull/1680#pullrequestreview-2192263866
PR Review Comment: https://git.openjdk.org/skara/pull/1680#discussion_r1686971715